Problem/Motivation

The mjml_preview.settings_form route is not in the admin menu.

Steps to reproduce

Proposed resolution

We need to add a .links.menu.yml file: https://www.drupal.org/docs/drupal-apis/menu-api/providing-module-define...

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork mjml_preview-3562078

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff’s picture

prudloff commented
Issue tags: +Novice

priyansu18 made their first commit to this issue’s fork.

priyansu18 opened merge request !1

priyansu18’s picture

priyansu18 commented
Status: Active » Needs review
sujal kshatri’s picture

sujal kshatri commented

I wanted to work on this issue, but priyanshu has already made a MR but one small thing I wanted to flag for consideration: the menu link parent is set to system.admin_config_services. Since this is a preview/tooling-related page, it might be worth checking whether system.admin_config_development would be a slightly better fit.

Just sharing this as a minor suggestion

mjml_preview.settings_form:
  title: 'MJML Preview'
  description: 'Configure MJML preview settings.'
  route_name: mjml_preview.settings_form
  parent: system.admin_config_development
  weight: 10
prudloff’s picture

prudloff commented

Yeah, I was not really sure where to put this in the menu (it is not really a dev tool, it can be used in production).
For now the URL is /admin/config/services/mjml_preview so I guess it makes sense to use system.admin_config_services as a parent.

priyansu18’s picture

priyansu18 commented

While the MJML preview settings are indeed not strictly a dev tool and could be used in prod, I believe, using system.admin_config_services seems more appropriate.

sujal kshatri’s picture

sujal kshatri commented

Got it! thanks

prudloff’s picture

prudloff commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.