Problem/Motivation

According to the last CI pipeline run, there's a few CSPELL/PHPCS/PHPSTAN issues to fix: https://git.drupalcode.org/project/simple_sitemap/-/pipelines/671337

Steps to reproduce

Please see link above

Proposed resolution

Fix the code style issues.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork simple_sitemap-3561997

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

danrod created an issue. See original summary.

shamir.vs made their first commit to this issue’s fork.

shamir.vs opened merge request !139

danrod’s picture

danrod
Location Ottawa
commented

Hi @shamir.vs is this MR ready? I still see the CI warnings that need to be addressed.

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Needs work
shamir.vs’s picture

shamir.vs commented
Status: Needs work » Needs review

I have created a merge request to address issues related to CSPELL, PHPCS, and PHPSTAN. Please take a moment to review it. Thank you!

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community

Hi

I reviewed MR!139, confirmed that the CSpell, PHPCS, and PHPStan are now passed in GitLab CI.

Moving this to RBTC!
Thank you.

anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

Still some phpcs and phpstan issues to resolve.

daniel.j made their first commit to this issue’s fork.

daniel.j changed the visibility of the branch 3561997-fix-cspell-phpcs to hidden.

daniel.j changed the visibility of the branch 3561997-fix-cspell-phpcs to active.

daniel.j’s picture

daniel.j commented
Status: Needs work » Needs review

Added fixes for phpstan and phpcs, whose jobs are now passing.

  • gbyte committed 9a3303d8 on 4.x authored by shamir.vs 
    task: #3561997 Fix CSPELL, PHPCS and PHPSTAN issues

By: danrod
By:...
gbyte’s picture

gbyte
Location Berlin
commented
Status: Needs review » Fixed

Thank you all.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.