Problem/Motivation

Cookie should be flagged as HttpOnly, Secure and SameSite=Lax

Steps to reproduce

Install and configure the module with a Commerce based site
Clear the site's cookies in the browser
Visit any page and use the browser tools to inspect the module's currency cookie

Proposed resolution

Edit the call to setrawcookie in CurrencyResolveCookieSelectForm::submitForm. There is a second form of this PHP function that allows an options array to be passed including all these options.

Remaining tasks

Write the patch

User interface changes

None

API changes

None

Data model changes

None

Issue fork commerce_currency_resolver-3561310

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rory downes created an issue. See original summary.

rory downes’s picture

rory downes commented
Status: Active » Needs review

I have created the solution in the fork branch. I could not work out how to create the merge request. I went to the compare page but could not see a button to do this.
Otherwise it is ready for review
Regards Rory

valic opened merge request !17

valic made their first commit to this issue’s fork.

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Needs review » Fixed

Tnx

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.