Problem/motivation

Linkit adds data-entity-type="external" to external URLs, which causes the Entity share module to break when syndicating content ( reported in https://www.drupal.org/project/entity_share/issues/3551951 )

Steps to reproduce

Set up a server site and client site with entity share module, and relevant channels to synchronise content across the two sites. When a node that is to be synchronised includes an external link with this attributes, the entity share module throws an error and the syndication does not occur.

Proposed resolution

Include a configuration option to not add the external attribute, as this is not an actual entity type.

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.

Issue fork linkit-3560913

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

telegraph created an issue. See original summary.

telegraph’s picture

telegraph commented

Would there be a way to make adding data-entity-type="external" to external URLs optional or de-activate it?

mark_fullmer made their first commit to this issue’s fork.

mark_fullmer opened merge request !154

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Active » Needs review

At this point in time, Linkit does not need the data-entity-type to indicate "external" for external links. This was added as a workaround, and its removal will have no negative effects on the metadata or processing of links. I've opened a merge request to remove it.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.