Problem/Motivation

The page--focused.html.twig template on line hardcodes block IDs belgrade_checkout_progress and belgrade_page_title:

{{ page.content|without(['belgrade_checkout_progress', 'belgrade_page_title']) }}

When creating a subtheme of Belgrade:
These block IDs are theme-specific and won't exist in the subtheme unless explicitly recreated
Subthemes may use different block IDs or not use these blocks at all
The template assumes these specific block instances exist, which violates Drupal's subtheme pattern
Subthemes must override the entire template to change this behavior

Issue fork belgrade-3560766

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

majmunbog created an issue. See original summary.

majmunbog opened merge request !70

majmunbog’s picture

majmunbog commented
Status: Active » Needs review

We are now using active theme variable to exclude or include some blocks. Subheming should be working ok now.

sumi’s picture

sumi commented
Status: Needs review » Reviewed & tested by the community

Tested with both creating starerkit and subtheme and in both cases focused checkout didn't include the unwanted blocks.

  • majmunbog committed c7186348 on 3.x 
    fix: #3560766 Hardcoded block IDs in focused page template break...
majmunbog’s picture

majmunbog commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.