Problem/Motivation

  • When "Display element description as help text (tooltip)" is disabled, help text displays in white font on white background.

Steps to reproduce

  • Go to simplytest.me, launch sandbox with webform 6.3.0-beta5 on Drupal 11.1.9
  • Go to /admin/structure/webform/config/advanced, disable "Display element description as help text (tooltip)"
  • Create a new webform and add a new element, e.g. checkbox
  • Notice that help text displays in white font on white background:
    Screenshot showing white text on white background

Proposed resolution

  • Change the font color

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#14 Untitled.png270.57 KBandrew.wang
pngout.png168.58 KBandrew.wang

Issue fork webform-3560696

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andrew.wang created an issue. See original summary.

santanu mondal made their first commit to this issue’s fork.

santanu mondal’s picture

santanu mondal commented

Working on it..

santanu mondal opened merge request !780

santanu mondal’s picture

santanu mondal commented
Status: Active » Needs review

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.3.0-beta5 » 6.3.x-dev
andrew.wang’s picture

andrew.wang commented
Related issues: +#3569060: Form item descriptions nearly impossible to read in the off canvas dialog
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Is this problem new with 6.3.x or also in 6.2.x?

andrew.wang’s picture

andrew.wang commented

It seems to be 6.3.x only - my production site runs 6.2.9 and does not observe this issue. When I tried to upgrade to 6.3.x locally (or test with a blank site on simplytest.me) the issue manifests.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Where does the white color come from? Generally, color and background-color should be set together to avoid problems like this.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

#3569060: Form item descriptions nearly impossible to read in the off canvas dialog has been fixed. Please check if this is still a problem. If so, please find the commit that broke it; git bisect is useful for this.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Postponed (maintainer needs more info)
andrew.wang’s picture

andrew.wang commented
Status: Postponed (maintainer needs more info) » Fixed
StatusFileSize
new Untitled.png270.57 KB

This is fixed now!Image showing desciprtion text is now property showing below the form fields.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland closed merge request !780