Problem/Motivation

There are words in cspell:ignore lines that are no longer needed.

Steps to reproduce

Proposed resolution

Run the attached script and removed identified words. Also check the words with apostrophes.
Remove commas from the ignore lines.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3560682-nr-bot_fjn8bw_9.txt91 bytesneeds-review-queue-bot
cspell-check-ignored.sh_.txt1.1 KBquietone

Issue fork drupal-3560682

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14000

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review

Linting has passed so setting to 'Needs review'

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems some additional spaces were added in the navigation.css, seems minor but now the comments appear to be floating from the css block they're suppose to be on.

If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Needs review

I've rebased and ran the script again, which found more words that can be removed.

xjm’s picture

xjm
she/her
Primary language English
commented
Parent issue: » #3622977: [12.x] Drupal 12.0 (and 11.5) beta targets
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3560682-nr-bot_fjn8bw_9.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone opened merge request !17279

quietone’s picture

quietone commented
Status: Needs work » Needs review

Rebased and re-ran script.

Also, made an 11.x MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Changes seem fine. Going to mark so you don't have to re-run again hopefully.