I am requesting Security Advisory Coverage for the AWS Manager module.

The module now has a stable release (1.0.0), follows Drupal coding standards, and is actively maintained.
I agree to fix any reported security issues promptly and coordinate with the Drupal Security Team.

The module does not contain intentionally insecure functionality, and I will maintain security best practices going forward.

Thank you for reviewing this request.

Project link

https://www.drupal.org/project/aws_manager

Comments

anandaakrishnan-ga created an issue. See original summary.

vishal.kadam’s picture

Title: Request Security Advisory Coverage for aws_manager module » [1.0.x] Aws Manager
Category: Support request » Task
Issue summary: View changes
Priority: Major » Normal
avpaderno’s picture

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • New releases are not necessary for these applications, which could require changes that are not backward-compatible. Not creating new releases avoids any possible issue.
  • Please do not change the branch to review once reviews started, except in the case the used branch needs to be deleted.
  • If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
  • For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
  • Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

avpaderno’s picture

Remember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.

avpaderno’s picture

Status: Active » Closed (won't fix)

I am closing this application because its status was Active and it was not changed in the past 14 days.

Feel free to re-open this application, if you are the applicant and you are sure you can follow it the time necessary to get it closed as fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.