Problem/Motivation

The attribute title="(Opens in a new window)" is added to all external links, not taking into account whether the link actually opens in a new window. In https://www.drupal.org/project/extlink/issues/3468454, the issue was reported and fixed.
The changes from https://www.drupal.org/project/extlink/issues/3523382 have partially overwritten some of these changes. As a result, the attribute is again added to all external links.

Steps to reproduce

  • Disable the checkbox 'Open external links in a new window or tab.' on /admin/config/user-interface/extlink
  • Add an external link to a page
  • Hover over the external link, the text '(Opens in a new window)' will be shown

Issue fork extlink-3559784

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grietdk created an issue. See original summary.

grietdk opened merge request !58

smustgrave closed merge request !58

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !60

  • smustgrave committed f0bc691d on 2.0.x 
    Resolve #3559784 "Hasnewwindowtext title attribute"
smustgrave’s picture

smustgrave commented
Status: Active » Fixed

Went with a different approach and added test coverage thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.