Problem/Motivation

The latest release of entity_usage added more parameters to ListUsageController::__construct and these break the parent construct call in entity_usage_plus/src/Controller/LocalTaskUsagePlusController.php

Avoid dependence on the parent controller construct class by using the create() method instead.

Issue fork entity_usage_plus-3559728

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jastraat created an issue. See original summary.

jastraat opened merge request !2

jastraat’s picture

jastraat commented
Status: Active » Needs review
theloneliestmonk’s picture

theloneliestmonk commented
Status: Needs review » Reviewed & tested by the community

The code looks fairly straightforward and solid.

  • jastraat committed 5441e103 on 1.0.x 
    bug: #3559728 Use create() instead of ___construct to set properties in...
jastraat’s picture

jastraat commented
Status: Reviewed & tested by the community » Fixed

Thank you @theloneliestmonk!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jastraat’s picture

jastraat commented

Opened an issue in entity_usage in case other modules were extending its controller class: #3559886: Set default values on optional construct() parameters.. The commit from this issue provides a workaround for entity_usage_plus.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.