Problem/Motivation

I'd strongly recommend to enable PhpStan tests and fix all the issues. That's the only way to make sure that the module doesn't crash any Drupal sites.

Proposed resolution

I'll work on this and propose an MR with all required changes to get the test green.

Issue fork wa-3559549

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !2

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review

The attached MR tests green for Drupal 11 now on level 6 for PhpStan. However, cleaning up the code unveiled a couple of code issues that you may want to review carefully. I think there have been bugs being found. I also left a few @todo comments in the code for you.

This should then also be tested against Drupal 10 once the MR from #3559539: Misconfiguration of Drupal core dependency got merged.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

All tests are now green, and it tests against current (11.2), next minor (11.3), and previous major (10.5). That way, you can be pretty sure that updates are safe, and you get early warnings in case any upstream changes will require updates in the codebase of this module.

  • mingsong committed b675cac9 on 1.0.x 
    Issue #3559549 by jurgenhaas, mingsong: Enable PhpStan tests in...
mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Needs review » Fixed

Thank you.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mingsong closed merge request !2