Hide “Flag as required” checkbox when field is not required

Working...

I have raised a MR and I have checked it locally it is working fine.

I need to review this.

From memory, this was originally just a user facing UI feature to indicate parts of the name were required. For example, given and family were both required for a valid name albeit the name field itself was optional.

-      '#description' => $this->t('This automatically validates for empty fields, and flags inputs as required.'),
+      '#description' => $this->t('This applies the required attribute if the component is required as part of a complete name, which causes most browsers to validate for empty fields.'),

Is this feature broken now? At least one other issue that seems to have been committed without understanding what this was for...

I'm unsure if that feature was carried into the original D8 port and if it was covered by the ported tests, but it sounds like it may need a quick review to see if it's still working. It's purely decorative! It should have never directly added the standard browser validation to a fully empty field, blocking the parent form submission when empty!

This was effectively what it did do in Drupal 7, basically an asterisk with some title text explaining why there was an asterisk.

function theme_name_component_required_marker($variables) {
  $base_element = $variables['base_element'];
  $components = $variables['components'];
  $component_key = $variables['component_key'];
  $name_translations = _name_translations();
  $title = empty($base_element['#title']) ? t('Name') : $base_element['#title'];
  if (!empty($base_element['#allow_family_or_given']) && ($component_key == 'given' || $component_key == 'family')) {
    $title_attribute = t('!given_title or !family_title is required when entering a !title.', array(
      '!given_title' => empty($components['given']['title']) ? $name_translations['given'] : $components['given']['title'],
      '!family_title' => empty($components['family']['title']) ? $name_translations['family'] : $components['family']['title'],
      '!title' => $title,
    ));
  }
  else {
    $component_title = empty($components[$component_key]['title']) ? $name_translations[$component_key] : $components[$component_key]['title'];
    $title_attribute = t('!component_title is required when entering a !title.', array('!component_title' => $component_title, '!title' => $title));
  }
  // Both field label and component labels have already been sanitized.
  return ' <span class="name-required-component-marker" title="' . $title_attribute . '">' . variable_get('name_component_required_marker', '*') . '</span>';
}

The Drupal 7 admin text was "'Appends an asterisk after the component title if the component is required as part of a complete name.'".

As an aside, I remember prototyping various front end options to indicate this to the field itself, but most just cluttered the form / made it more confusing. It's possible this does make some users unnecessarily type in something into the name field, but it was never raised as an issue prior to 2018 and there was a built-in way to indirectly modify this with a variable override (no admin UI though) and the theming function itself.

Edit: re-reading this, this could apply to a new feature? I decided against additional custom validation back in the day as it would definitely need custom client side jscript validation to be implemented correctly.

I reverted the changes.