Problem/Motivation

https://docs.gitlab.com/ci/runners/configure_runners/#custom-build-direc... mentions we can just set GIT_CLONE_PATH if we need a custom build directory.

This means we can remove the workaround where we copy various files about to ensure that they always contain the same static path.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3559003

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [CI] Unify lint cache scripts » [CI] Use bind mounts to simplify CI scripts
Issue summary: View changes

Repurposing this as the unification is in #3558749: [CI] Refactor lint cache downloads and allow easier testing instead.

longwave opened merge request !13880

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [CI] Use bind mounts to simplify CI scripts » [CI] Set GIT_CLONE_PATH to a static path
Status: Active » Needs review

This seems to work - setting GIT_CLONE_PATH to $CI_BUILDS_DIR means everything always starts in /builds, so we don't need to copy things around.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

The sed commands in the PHPStan job appear to do nothing, because the baseline is already relative to __DIR__, so I've removed those. This is ready for review now I think.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Added a comment, thanks @alexpott for the suggestion.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

This is inspired. Nice.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Great find.

  • catch committed 575e9b37 on 11.x 
    task: #3559003 [CI] Set GIT_CLONE_PATH to a static path

By: @longwave...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed c5d1b06c on 11.3.x 
    task: #3559003 [CI] Set GIT_CLONE_PATH to a static path

By: @longwave...

catch closed merge request !13880

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.