Problem/Motivation

It would be really helpful if \Drupal\checklistapi\Storage\StorageBase implemented CacheableDependencyInterface and we invalidated a cache tag everytime we saved a checklist progress. This would allow me to fix #3558887: Update Helper checklist integration makes the toolbar uncachable.

Steps to reproduce

See #3558887: Update Helper checklist integration makes the toolbar uncachable.

Proposed resolution

Implement the interface and invalidate the cache tags on save or deletion of progress.

Remaining tasks

User interface changes

N/a

API changes

\Drupal\checklistapi\Storage\StorageBase implemented CacheableDependencyInterface

Data model changes

None

CommentFileSizeAuthor
#4 18.diff6.3 KBalexpott

Issue fork checklistapi-3558919

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !18

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 18.diff6.3 KB

Uploading patch for me to play with...

traviscarden’s picture

traviscarden commented
Status: Needs review » Fixed

Nice, thanks, @alexpott!

I don't know what the whole merge train comment there is about, but I did merge the MR, and the commit is in 2.1.x.

Would you like a release?

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@traviscarden yes would love a release - what about the 3.0.x branch?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Oh and thanks for looking at this and merging it!

alexpott opened merge request !19

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Created a 3.0.x MR for ya - https://git.drupalcode.org/project/checklistapi/-/merge_requests/19

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.