i checked out the 4-6 branch from cvs, but i had some problems with it.

some functions return the output instead of using theme('page'), as an effect there isn't any output on a lot of pages.

there were some incompabilities with php5.0.5, these are addressed with this patch to.

fix attached

CommentFileSizeAuthor
project-46-php.patch11.61 KBfago

Comments

moggy’s picture

moggy commented
Status: Needs review » Reviewed & tested by the community

yep, does indeed fix a few problems. +1

had a problem with issues.inc having windows line breaks preventing the patch applying, but that's easy to fix.

-1 to me for closing an identical issue yesterday because I thought it had already been done :oops:

detki’s picture

detki commented

Hey guys I try out the patch, but i wasn't good for me.
May be there is something in the 160-161 rows in the given descripton:
- if ($node->type == 'project_project') {
+ if ($node->type == 'project_project') {

I couldn't find the differences between these two lines.
Those are in the project.module somewhere @@ -244,7 +247,7 @@
Every help will welcome! Thanks.

tclineks’s picture

tclineks commented

Hey guys I try out the patch, but i wasn't good for me.
May be there is something in the 160-161 rows in the given descripton:
- if ($node->type == 'project_project') {
+ if ($node->type == 'project_project') {

An extra space exists at the end of the new line in the patch.

Otherwise it looks clean to me.

Using -F^func (or similar) as an argument to diff helps reviewers (this will identify the function the difference resides in.

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: 4.6 branch: blank pages » 4.6 branch: blank pages && php5issues
dww’s picture

dww
we/he/they
commented
Title: 4.6 branch: blank pages && php5issues » 4.6 branch: php5 issues
Priority: Critical » Normal
Status: Reviewed & tested by the community » Needs work

i had previously fixed some of the blank page problems, and just applied the patch from #57174 which fixes the rest. if you still care about the php5 issues in 4.6, please make a new patch that only fixes those. and yeah, please avoid extra whitespace at the ends of lines. thanks.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Closed (won't fix)

4.6 is dead.