Problem/Motivation

The module is unfortunately lacking several quality of life improvements. Some of the quality of life improvements I feel this module should have are:

UI based configuration for various options:

#1, Configure whether to include only tracking only for anonymous users, only for logged in users, or for all users directly in the UI.
#2, Configure the 'excluded route' matches directly in the UI.

Proposed resolution

Expose configuration options in the configuration form, instead of having them hard-coded into the module.

User interface changes

Create two additional fields:

Select list - Track For - Anonymous Only, Authenticated Only, All Users
Textarea - Excluded Route Matches

In addition, Drupal 11 support should be added and the external library should be attached to the pages as needed.

Issue fork siteimprove_analytics-3558630

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jfurnas created an issue. See original summary.

jfurnas’s picture

jfurnas commented
Issue summary: View changes
jfurnas’s picture

jfurnas commented

I am currently working through this, and getting it in a good place. Will hopefully have it finalized in a day or so and can get it ready for review.

jfurnas changed the visibility of the branch 3558630-qol-improvements to hidden.

jfurnas opened merge request !2

jfurnas’s picture

jfurnas commented
Status: Active » Needs review

grask0 made their first commit to this issue’s fork.

grask0’s picture

grask0 commented
Version: 2.0.0 » 2.1.x-dev
grask0’s picture

grask0 commented
Assigned: jfurnas » Unassigned
Status: Needs review » Reviewed & tested by the community

Hey,

Thanks, guys, for your work on this issue!
I have created a new branch 2.1.x and a new 2.1.x DEV release.
Also updated the code and fixed several issues.

jfurnas’s picture

jfurnas commented

Thanks for picking this up grask0. I was originally just trying to get this into an improved state over what it was in previously, and got overwhelmed with all the teeny tiny details that were being asked to be changed.

grask0’s picture

grask0 commented
Status: Reviewed & tested by the community » Fixed

Thank you @jfurnas, for this hard work! It would have been difficult to accomplish all of this without your changes!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

grask0’s picture

grask0 commented

Also, Andy Fowlston (andyf), thanks for your help as well!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.