Problem/Motivation

Per #3557814: Related/parent links causing validation errors with automated issue comments. Link module adds a series of properties on render that are not present at the moment of comparing link fields, therefore always reporting changes, even if there aren't any.

Steps to reproduce

Create link fields, add a value to a node initially. Then edit it in two separate tabs, changing other values that are NOT the link. The links will always be reported as changed.

Proposed resolution

Only check the "original_*" properties from the link fields, as all the others can be changed via prerender templates/hooks. The "link" module alone adds a good number of properties, not present in the "old" value.

Remaining tasks

MR

Issue fork conflict-3558225

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin opened merge request !17

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

With this MR, we ignore all properties except for the "original_url" and "original_title" when there is a link field. I tried with two fields, one with cardinality set to 1 and the other to unlimited, and the values are always arrays.

  • drumm committed c7900a2a on 7.x-1.x authored by fjgarlin 
    fix: #3558225 Link module adds properties on render and always reports...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Looks good to me, merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.