Problem/Motivation

Following with: Drupal Core updates on nodejs and yarn.. also the default linting and Gitlab CI

Proposed resolution

Change to

  "license": "GPL-2.0-or-later",
  "private": true,
  "engines": {
    "yarn": ">= 4.9.3",
    "node": ">= 20.0"
  },

and

  "packageManager": "yarn@4.9.3"
  • Add the .yarnrc.yml file.
  • Update dependencies to follow with Drupal Core package.json file
  • Update the yarn.lock file.
  • Add .cspell.json file
  • Check this link to see how to switch yarn to 4.9.3 or 4.9.4 in your local.
  • Add .gitlab-ci.yml file with basic build and linting
  • Add README.md documentation for all submodules and update the main README.md file

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ✅ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ✅ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release admin_audit_trail-1.0.6

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • chore(tooling): #3557726 Update Node.js to >=20.0 and Yarn to 4.9.3 for Admin Audit Trail module to align with Drupal Core with GitLab CI/CD
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes

  • rajab natshah committed 43f47ee2 on 1.0.x
    chore(tooling): #3557726 Update Node.js to >=20.0 and Yarn to 4.9.3 for...

  • rajab natshah committed cff025c1 on 1.0.x
    chore(tooling): #3557726 Add .gitlab-ci.yml file with basic build and...

  • rajab natshah committed 70ce2149 on 1.0.x
    chore(tooling): #3557726 Add .gitlab-ci.yml file with basic build and...

  • rajab natshah committed 5d950c36 on 1.0.x
    chore(tooling): #3557726 Add README.md documentation for all submodules...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: rajab natshah » s.halawani
Issue summary: View changes
Issue tags: +admin_audit_trail-1.0.5
rajab natshah’s picture

Assigned: s.halawani » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.