Problem/Motivation

In Display Builder, dragging a component with variants but without a selected variant trigger this warning:

Undefined array key "variant_id" in ComponentSource::settingsSummary()

Proposed resolution

Add a check

Issue fork ui_patterns-3557682

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Active » Needs review

pdureau opened merge request !463

juc1’s picture

juc1 commented

I have tried the update but I think I still get the same warning (previously was line 129, now line 131)

Warning: Undefined array key "variant" in Drupal\ui_patterns\Plugin\UiPatterns\Source\ComponentSource->settingsSummary() (line 131 of /web/modules/contrib/ui_patterns-3557682-2.0.x/src/Plugin/UiPatterns/Source/ComponentSource.php)

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau
Status: Needs review » Needs work

thanks @juc1. I will have a look

mogtofu33 made their first commit to this issue’s fork.

pdureau’s picture

pdureau commented
Issue tags: +display_builder-1.0.0-beta
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

can i take this issue ?

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: pdureau » just_like_good_vibes
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » pdureau
Status: Needs work » Needs review

someone can review?

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Needs review » Reviewed & tested by the community

It is OK for me

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.