Problem/Motivation

Add Dumbbell as an option for Highcharts: https://www.highcharts.com/docs/chart-and-series-types/dumbbell-series

How to test

CommentFileSizeAuthor
#13 first_row_dumbbell.png184.46 KBandileco
#10 charts_highcharts_dumbbell.mp411.72 MBandileco
#10 charts_highcharts_dumbbell_field.mp47.32 MBandileco

Issue fork charts-3557173

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bspeare created an issue. See original summary.

andileco’s picture

andileco commented

@bspeare - I'm definitely open to adding this. Are you able to take a first attempt and have me review it?

bspeare’s picture

bspeare commented

@andileco thanks for being open to this. Yes, I will create a branch to get things started.

bspeare’s picture

bspeare commented
Issue summary: View changes

bspeare opened merge request !181

andileco’s picture

andileco commented

@bspeare, is this ready for review? If so, can you change the status and assign to me?

bspeare’s picture

bspeare commented
Status: Active » Needs review
bspeare’s picture

bspeare commented

Thanks for checking in @andileco, I don't see an option to assign you.

andileco’s picture

andileco commented
Assigned: Unassigned » andileco

No worries, I've assigned myself.

andileco’s picture

andileco commented
Assigned: andileco » Unassigned
StatusFileSize
new charts_highcharts_dumbbell_field.mp47.32 MB
new charts_highcharts_dumbbell.mp411.72 MB

@bspeare, please review. I have attached a video displaying the output. I think the main difference is if you're in Views, using the Numeric Array field. If you are using a chart field, you can actually type into a cell the low number followed by a comma then the high number (e.g. 74.7, 83.2). See the two attached videos.

bspeare’s picture

bspeare commented

Thank you for the quick review and refactoring @andileco! I like your changes using the low number and high number in a single cell. What about if the chart needs different legends like in this poverty rate example on https://www.highcharts.com/blog/tutorials/why-you-need-to-start-using-du...?

Also, what are your thoughts on how it renders using the "First row" option? In particular, what do you see in the tooltip when you switch to that option?

andileco’s picture

andileco commented

Interesting... in those examples, they use the subtitle as a legend. Will look at the first row question soon.

andileco’s picture

andileco commented
StatusFileSize
new first_row_dumbbell.png184.46 KB

If you want to use the "first row" option, you'd need your data entered like in the attached picture, where each column is a country and the row is life expectancy.

Good to move to RTBC?

bspeare’s picture

bspeare commented
Status: Needs review » Reviewed & tested by the community

Thanks @andileco. I think we are good for RTBC.

andileco’s picture

andileco commented
Status: Reviewed & tested by the community » Needs work

Realizing I need to add into the README, package.json, and composer.json.

andileco’s picture

andileco commented
Status: Needs work » Fixed

Merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.