Problem/Motivation

Contact module is being deprecated. Usages is tests not in Contact needs to removed and test coverage moved to the Contact module.

contact.settings is used in \Drupal\Core\Config\Schema\SchemaCheckTrait. Can this just be removed? See related issue #3425992: contact.settings, filter.settings, etc. all have dependencies, which violates the basic rule of simple config

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3557105

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I'm not sure if this can just be removed. It would need to be duplicated into all contact tests that trigger this, which could be a lot. Including contrib tests such as contact_storage which would then break without this as well. I guess it will need to happen eventually as they are moved out of core. Start by removing it and seeing which tests break I suppose. Then add it back in setup() of those specific tests.

quietone opened merge request !13780

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs work
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

This is worse than I thought because it also affects Tests that enable all modules of course.

We'd need a trait that unifies skipping some modules and update them all .

But I wouldn't bother. Not now. This is not a blocker, it will not fail if contact is removed, it is an exclude list.

And I think I disagree with how it was done in the first place. We imho shouldn't trigger errors for something that can't be fixed.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3425992: contact.settings, filter.settings, etc. all have dependencies, which violates the basic rule of simple config

As I see it does not affect deprecation so could be close in favour of existing TODO #3425992: contact.settings, filter.settings, etc. all have dependencies, which violates the basic rule of simple config

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Closed (won't fix)

I agree with @berdir, there is no point in adding boilerplate for this now to tests. So won't fix then.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.