The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Contact module is being deprecated. Usages is tests not in Contact needs to removed and test coverage moved to the Contact module.
ajax_test has a dependency on the contact module.
Steps to reproduce
Proposed resolution
Remaining tasks
Investigate how contact is used by tests using 'ajax_test'.
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3557103
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3557103-change-use-of
changes, plain diff MR !14444
Comments
Comment #2
berdir\Drupal\FunctionalJavascriptTests\Ajax\DialogTest also explicitly relies on contact, not (only) through ajax_test. That will need to be adjusted too. The test will need to use a different entity type.
Comment #4
quietone commentedI tried to move the necessary code to the ajax_test module itself.
Comment #5
dcam commentedThere's a failure in the Nightwatch tests,
Tests/ajaxExecutionOrderTest. It looks like it may be related.Comment #6
quietone commentedCreated a new test module instead of adding to ajax_test.
Comment #7
quietone commentedComment #8
smustgrave commentedPipeline is all green and don't have any additional feedback. LGTM
Comment #9
dcam commentedWhat I was trying to figure out is if there is a need for the entity type and form. It seems like this test could be made on a simple controller. But maybe I'm missing something.
Comment #10
catchI think that would be a cleaner test, not necessarily much less code though because there'd need to be a bit more form definition probably that we wouldn't get from an entity form.
Since this is the last remaining contact deprecation blocker, going to go ahead here but we could try to simplify the test in a follow-up.
Committed/pushed to main and 11.x, thanks!
Comment #15
catch