Problem/Motivation

Contact module is being deprecated. Usages is tests not in Contact needs to removed and test coverage moved to the Contact module.

ajax_test has a dependency on the contact module.

Steps to reproduce

Proposed resolution

Remaining tasks

Investigate how contact is used by tests using 'ajax_test'.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3557103

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

\Drupal\FunctionalJavascriptTests\Ajax\DialogTest also explicitly relies on contact, not (only) through ajax_test. That will need to be adjusted too. The test will need to use a different entity type.

quietone opened merge request !14444

quietone’s picture

quietone commented
Status: Active » Needs review

I tried to move the necessary code to the ajax_test module itself.

dcam’s picture

dcam commented
Status: Needs review » Needs work

There's a failure in the Nightwatch tests, Tests/ajaxExecutionOrderTest. It looks like it may be related.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Created a new test module instead of adding to ajax_test.

quietone’s picture

quietone commented
Version: 11.x-dev » main
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Pipeline is all green and don't have any additional feedback. LGTM

dcam’s picture

dcam commented

What I was trying to figure out is if there is a need for the entity type and form. It seems like this test could be made on a simple controller. But maybe I'm missing something.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

I think that would be a cleaner test, not necessarily much less code though because there'd need to be a bit more form definition probably that we wouldn't get from an entity form.

Since this is the last remaining contact deprecation blocker, going to go ahead here but we could try to simplify the test in a follow-up.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 27101637 on 11.x 
    task: #3557103 Change use of Contact in ajax_test test module

By:...

  • catch committed 7f8c63e2 on main 
    task: #3557103 Change use of Contact in ajax_test test module

By:...

catch closed merge request !14444

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.