Problem/Motivation

Latest build pipeline reports errors for the PHPCS validation job:
https://git.drupalcode.org/project/collapse_text/-/jobs/7201050

FILE: src/Plugin/Filter/CollapseText.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 153 | ERROR | String concat is not required here; use a single string instead
     |       | (Generic.Strings.UnnecessaryStringConcat.Found)
------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run build pipeline at:
https://git.drupalcode.org/project/collapse_text/-/pipelines/new

Proposed resolution

Fix reported error.

Issue fork collapse_text-3556760

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dydave created an issue. See original summary.

dydave opened merge request !10

  • dydave committed a954e1c0 on 2.0.x 
    Issue #3556760 by DYdave: Gitlab CI: Fixed PHPCS validation error.
dydave’s picture

dydave commented
Status: Active » Fixed

Quick follow-up on this issue:

Fixed PHPCS validation error by removing unnecessary string concatenation.

Create merge request MR !10 above at #2 and since all the jobs and tests came back green again 🟢, I went ahead and merged the changes at #3. 🥳

We should now be able to tag a new stable release, which should at least get all the jobs and tests passing. 👌

Marking issues as Fixed, for now.

Thanks in advance for your reviews and feedback! 😊

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.