Seeing as Atomics is now widely available I think we should add some response headers so partytown can make use of it.

For me the biggest benefit would be getting rid of the very annoying proxytown requests but it may also bring some performance gains.

Any thoughts @abenbow?

Issue fork partytown-3555961

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rattusrattus created an issue. See original summary.

abenbow’s picture

Hey @rattusrattus, this looks really interesting! I wasn't aware that this was a feature we could support.

I'm taking a look at the docs on partytown and this looks pretty promising as something we could roll into the existing module.

It looks like if anything with the atomics system goes wrong, partytown falls back to the traditional service worker system, which is good in terms of feature detection and legacy support.

If I'm reading this correctly, we're essentially enabling two headers sitewide, correct? If so, I think we may need to provide a way for users to toggle that particular feature so they have some more fine grained control over if/when those headers show up in the response. At minimum, I'd propose a module hook so that administrators have some control over the experience for a given page or pages. A toggle in the admin UI would also be good.

What are your thoughts?

rattusrattus’s picture

Hi abenhow

Thanks for this. It looks good to me. Should we merge or is there more you wanted to do?

abenbow’s picture

Status: Active » Reviewed & tested by the community

I think we're clear to merge if you're satisfied with it. Thanks for taking a look!

abenbow’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.