Problem/Motivation

Since symfony/console 7.4: The "Symfony\Component\Console\Application::add()" method is deprecated and will be removed in Symfony 8.0, use "Symfony\Component\Console\Application::addCommand()" instead.

Steps to reproduce

Proposed resolution

Change references to the deprecated method.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3555528

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

aryan singh’s picture

aryan singh commented

Working..

aryan singh opened merge request !13649

aryan singh’s picture

aryan singh commented

The pipeline fails because the Drupal 11.x core still uses "symfony/console": "^7.3", where addCommand() method does not yet exist.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Postponed

Thanks for working on this - looks like this has to wait until #3554533: Update to Symfony 7.4.0-BETA2 is committed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed » Needs review

The related issue landed so this should be doable now.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Was hard to do a search for ->add( but did some spot checking and all instances calling Symfony console add I believe have been replaced.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a rebase.

quietone made their first commit to this issue’s fork.

quietone’s picture

quietone commented
Status: Needs work » Reviewed & tested by the community

Rebase with a simple conflict in .deprecation-ignore.txt. Tests are passing so setting back to RTBC.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Since symfony/console 7.4: The "Symfony\Component\Console\Application::add()" method is deprecated » \Symfony\Component\Console\Application::add() is deprecated in Symfony 7.4
xjm’s picture

xjm
she/her
Primary language English
commented
Title: \Symfony\Component\Console\Application::add() is deprecated in Symfony 7.4 » Symfony\Component\Console\Application::add() is deprecated in Symfony 7.4
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -Novice
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13649

  • catch committed 94a884fb on 11.3.x 
    fix: #3555528 Symfony\Component\Console\Application::add() is deprecated...

  • catch committed 4e7cd760 on 11.x 
    fix: #3555528 Symfony\Component\Console\Application::add() is deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

maheshv’s picture

maheshv commented

I ran the frontend command after upgrading Drupal to version 11.3.5, but I am still encountering this issue.

ERROR: Since symfony/console 7.4: The "Symfony\Component\Console\Application::add()" method is deprecated and will be removed in Symfony 8.0, use "Symfony\Component\Console\Application::addCommand()" instead.
in /app/vendor/symfony/deprecation-contracts/function.php:25

maheshv’s picture

maheshv commented

Is this code available in Drupal 11.3.5? I didn't see it in the release notes.

cilefen’s picture

cilefen commented

@maheshv, Drupal Core corrected this deprecation. I have been suggesting in #3583418: ERROR: Since symfony/console 7.4: The Symfony\Component\Console\Application::add() is deprecated in Symfony 7.4 that what you see originates from Lando code.