Describe your bug or feature request.

While doing some cleanup on a project and deleting old promotions, I realized the view was still showing up deleted promotions after the deletion.

This is due to the fact that Promotion::postDelete() and Coupon::postDelete() skip calling the parent method, causing the cache tags invalidation to be skipped.
We should fix that, and eventually do the same for other entity types if we made the same mistake elsewhere.

Issue fork commerce-3555380

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jsacksick created an issue. See original summary.

khiminrm made their first commit to this issue’s fork.

khiminrm opened merge request !544

khiminrm’s picture

khiminrm commented
Status: Active » Needs review

  • jsacksick committed e55653c9 on 3.x authored by khiminrm 
    [#3555380] fix: Cache tags aren't invalidated on promotion / coupon...
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Merged thank you!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.