Problem/Motivation

The latest build pipelines of the 4.0.x branch seem to be failing with multiples jobs and errors, see:
https://git.drupalcode.org/project/block_class/-/pipelines/480442

These issues and errors mostly seem to be caused by API changes and the compatibility with D11.

In particular:
The page /admin/block-class/help returned through the BlockClassController class currently crashed with WSOD on D11, since system_get_module_admin_tasks() is deprecated as of D10.2.x.

Error: Call to undefined function Drupal\block_class\Controller\system_get_module_admin_tasks() in Drupal\block_class\Controller\BlockClassController->index() (line 101 of modules/contrib/block_class/src/Controller/BlockClassController.php).
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 622)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 36)
Drupal\Core\Test\StackMiddleware\TestWaitTerminateMiddleware->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 53)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 715)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Steps to reproduce

Run build pipeline for 4.0.x at:
https://git.drupalcode.org/project/block_class/-/pipelines

Or browse to: /admin/block-class/help
Check the error message above is displayed.

Proposed resolution

Fix reported PHPCS and PHPUNIT issues.

Issue fork block_class-3555338

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dydave created an issue. See original summary.

dydave opened merge request !66

  • dydave committed 0b5b887d on 4.0.x 
    Issue #3555338 by dydave: Fixed module's 'Help' page '...
dydave’s picture

dydave commented
Status: Active » Fixed

Quick follow-up on this issue:

All the changes detailed in the issue summary have been implemented and described in the merge request MR !66 above at #2.

The PHPCS errors were fixed as well.

Since all the tests and jobs seem to be passing 🟢 again, I went ahead and merged the changes above at #3.

This should at least unblock the testing pipeline for pending merge requests in the issue queue so we could at get a more complete validation before moving forward with the changes.

Marking issue as Fixed, for now.

Thanks in advance for your testing feedback, comments and reviews!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dydave’s picture

dydave commented
Issue summary: View changes
dydave’s picture

dydave commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.