See the attached patch which fixes this issue.

CommentFileSizeAuthor
bibcite_entity-deprecated-items.patch1.01 KBuberhacker

Issue fork bibcite-3555329

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

uberhacker created an issue. See original summary.

jatin.buzz’s picture

jatin.buzz commented
Assigned: Unassigned » jatin.buzz

Working On It!

jatin812 opened merge request !48

jatin.buzz’s picture

jatin.buzz commented
Assigned: jatin.buzz » Unassigned
Status: Active » Needs review

Reviewed the problem — it occurs because the checkFieldAccess() method in ReferenceAccessControlHandler defines the $items parameter with a default value of NULL but without explicitly marking it as nullable.
In newer PHP versions, this triggers the deprecation warning:
“Implicitly marking parameter $items as nullable is deprecated.”

This mainly causes deprecation notices in logs and could lead to future type compatibility issues.

I applied the patch, which makes the $items parameter explicitly nullable (?FieldItemListInterface $items = NULL).
The deprecation warning is gone and everything continues to work as expected.

Please review the MR.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Fixed

Thanks for the report and code, uberhacker, and thanks for the review, jatin812!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.