Add a UploadedFilesExtractor and remove duplicate code

Would this count as an API change? If it should get an MR.

Moving to NW as a number of functional tests seemed to fail.

Rebasing on main so we can see what the actual failures are.

I think this should be a service, passing in the current request seems wrong since every use requires that.

Ok I converted it to a service and identified the error:

Exception: Serialization of 'Symfony\Component\HttpFoundation\File\UploadedFile' is not allowed in serialize() (line 119 of core/lib/Drupal/Core/Batch/BatchStorage.php).

Drupal\Core\Batch\BatchStorage->create() (Line: 107)
Drupal\Core\ProxyClass\Batch\BatchStorage->create() (Line: 807)
batch_process() (Line: 56)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 624)
Drupal\Core\Form\FormBuilder->processForm() (Line: 347)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::wrapControllerExecutionInRenderContext():121}() (Line: 638)
Drupal\Core\Render\Renderer::{closure:Drupal\Core\Render\Renderer::executeInRenderContext():638}()
Fiber->resume() (Line: 653)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::onController():96}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 118)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 92)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 61)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 54)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 745)
Drupal\Core\DrupalKernel->handle() (Line: 19)

I did confirm that the same error occurs before I changed it to a service as well, so it shouldn't be my changes.

See my comments on the MR.

Seems to still have some test failures unfortunately.

Issue summary needs an update, \Drupal\Core\Render\Element\File::valueCallback() is no longer updated because that's different and weird.

maybe needs a change record?

That makes this a bit less useful as there's fewer places to unify, but I guess still useful as we build on it in the related issue?

Wondering if it would be cleaner/easier to test if request would be passed in to the method instead of the indirection with the request stack, but I think this is pretty common for us and I'm probably influenced by a recent book I've read.

Thanks for the feedback @berdir

- I've added a change record here https://www.drupal.org/node/3591900
- Issue summary updated.

I saw the commits and the changes in \Drupal\Core\Render\Element\File::valueCallback() have been reverted, so something might be awful there.

but I think this is pretty common for us and I'm probably influenced by a recent book I've read.

Just curious, which book you are talking about?

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

I updated the CR and issue summary a bit more, looks good to me.

> Just curious, which book you are talking about?

https://codethatships.com/

I read the comments, the MR and the change record. I have updated credit.

The last sentence of the change record refers to $form_field_name which is not used in the the change record. Is something missing from the change record? Setting to needs work for that.

@quietone, this looks like a typo change.
I checked the diff here https://www.drupal.org/node/3591900/revisions/view/14360985/14364088 and it seems a typo.
I've updated the change record.

Thanks @quietone! Feedback has been addressed!