Problem/Motivation

The latest build pipelines of the 3.0.x branch seem to be failing with multiples jobs an errors, see:
https://git.drupalcode.org/issue/block_class-3463832/-/pipelines/642633

These issues and errors mostly seem to be caused by API changes and the compatibility with D11.

Steps to reproduce

Run build pipeline for 3.0.x at:
https://git.drupalcode.org/project/block_class/-/pipelines

Proposed resolution

Fix reported PHPSTAN and PHPUNIT issues.

Issue fork block_class-3554895

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dydave created an issue. See original summary.

dydave opened merge request !65

  • dydave committed 8bd289e5 on 3.0.x 
    Issue #3554895 by dydave: Fixed failing tests compatibility with D11.
dydave’s picture

dydave commented
Status: Active » Fixed

Quick follow-up on this issue:

It happens the Bartik and Seven contrib themes have just released a stable Drupal 11 release \o/
Therefore, we're finally able to come back on #3463832: Disable Migrate D7 block_class Kernel tests for D11 to enable tests for all supported core versions.

All the changes detailed in the issue summary have been implemented and described in the merge request MR !62 above at #2.

The PHPSTAN errors were fixed by setting data provider method providerTest static.

Since all the tests and jobs seem to be passing 🟢 again, except for PHPUNIT tests for 11.3 (next minor) passing with warnings, I went ahead and merged the changes above at #3.

These warnings for the next minor should probably be further investigated in a follow-up ticket, but shouldn't block the current deployment pipeline from being stabilized, by moving forward with these changes.

We will most likely keep an eye on the upcoming changes of APIs, code deprecations, etc... and fix the warnings for 11.3.

Marking issue as Fixed, for now.

Thanks in advance for your testing feedback, comments and reviews!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dydave’s picture

dydave commented
Related issues: +#3463832: Disable Migrate D7 block_class Kernel tests for D11

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dydave changed the visibility of the branch 3554895-debug-opti-build to hidden.