Problem/Motivation

The version: VERSION lines in libraries.yml are creating a version query string using the Drupal Core version number for the asset files, making these files cached in the browser dependent on the Core version. I suggest to remove these.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cookies-3554735

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kaszarobert created an issue. See original summary.

kaszarobert opened merge request !136

kaszarobert’s picture

kaszarobert
Primary language Hungarian
commented
Issue summary: View changes
Status: Active » Needs review
kaszarobert’s picture

kaszarobert
Primary language Hungarian
commented
Issue summary: View changes
vinodhini.e’s picture

vinodhini.e commented

Hi @kaszarobert,

Tested this module on Drupal 11.2.3 and applied Merge Request #136.
Confirmed that all version: VERSION entries have been removed from the .libraries.yml file.
Thanks.

kaszarobert’s picture

kaszarobert
Primary language Hungarian
commented
Status: Needs review » Needs work

Hm, I wonder why doesn't it find that HTML element in the failing test all of the sudden.

tobiasb made their first commit to this issue’s fork.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs review » Reviewed & tested by the community

Patch does also apply to 1.2.x.

grevil’s picture

grevil commented

LGTM! Thanks.

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.