Use #attributes instead of #item_attributes

This will need a change record at least.

While this is covered by bc policy https://www.drupal.org/about/core/policies/core-change-policies/frontend...
I think it could be disruptive so we should document it. One minor comment on the mr too.

Definitely a CR. But the todo can it point to an issue too

tested locally. seems there are no other places to update. Attached screenshot after applying the patch.

let's wait for other reviewers to double check.

can we get a deprecation test please

Sorry small tweak can we bump to 11.4 think it’s too late for 11.3

Rest looks good though

I mean the deprecations

Thanks! Feedback appears to be addressed

I've rebased the branch on top of main.

Committed and pushed 85468ee47db to main and 54be7186870 to 11.x. Thanks!

We can open a follow-up on main to remove the deprecation and #item_attributes.

For the record, this did break for us on 11.4 because we had a preprocess hook that added something to the attributes of an image. Looking at https://search.tresbien.tech/search?q=%23item_attributes%20-r%3Adrupal&n..., I think at least lazy.module definitely is also affected by this. I identified 3 different cases that alter item attributes like that in our distribution,

I know we can change render arrays like that, still a pretty subtle change that isn't obvious if you don't have explicit test coverage or tests you can run on 11.x that trigger deprecations. And I'm not sure if changing template parameters is a render array change for the dozens of examples there that use #theme image_formatter (some use their own templates with their own item_attributes), so making it a D12 deprecation is maybe a bit tricky.

BC is hard, just also defining attributes woudn't help, which one do you then use, how do you figure out if item_attributes or attributes was altered?

@grimreaper: I suspect your ui_styles project might also be affected? https://git.drupalcode.org/project/ui_styles/-/blob/8.x-1.x/src/StylePlu..., the bit about THEME_WITH_ITEM_ATTRIBUTES isn't going to work anymore like that when it's different on different core minor versions?

Is there any chance we can have this behave more like this?

Something like this instead:

$variables['image']['#attributes'] = $variables['attributes'] ?? [];
if (isset($variables['item_attributes'])) {
    @trigger_error('Usage of #item_attributes is deprecated in drupal:11.4.0 and is removed from drupal:12.0.0. Use #attributes instead. See https://www.drupal.org/node/3554585', E_USER_DEPRECATED);
    $variables['image']['#attributes'] += $variables['item_attributes'];
}

Otherwise, anything set in $variables['attributes'] (like lazy = loading) will stop any modifications in $variables['item_attributes'] from applying.