Problem/Motivation

We update charts using CSV import. Some charts have colors that differ from the default configured colors. After uploading new data the colors revert back to default.

Our charts use the highcharts library and are added using paragraph types.

Steps to reproduce

Edit page with existing charts, then edit the paragraph containing a chart with colors that were manually changed to something different than the default colors. Upload updated data using the CSV importer. The data is updated, but the colors revert back to default.

Proposed resolution

We have solved it for now with a patch that edits ChartDataCollectorTable.php based on existing code. Perhaps there is a more elegant solution?

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 charts-3553827.patch1.59 KBannemiekb
charts-color-reset-on-csv-import-issue.patch1.69 KBannemiekb

Issue fork charts-3553827

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

annemiekb created an issue. See original summary.

annemiekb’s picture

annemiekb commented
Issue summary: View changes
StatusFileSize
new charts-3553827.patch1.59 KB

andileco made their first commit to this issue’s fork.

andileco opened merge request !179

andileco’s picture

andileco commented

Thank you, @annemiekb - I just created a MR with your patch to help benefit from the automated tests and make it a little easier for folks to work on the issue.

andileco’s picture

andileco commented
Version: 5.1.7 » 5.2.x-dev

andileco changed the visibility of the branch 5.2.x to hidden.

andileco opened merge request !220

andileco’s picture

andileco commented
Status: Active » Needs review

andileco changed the visibility of the branch 3553827-colors-revert-back to hidden.

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
Status: Needs review » Reviewed & tested by the community

  • andileco committed 9f02dfa5 on 5.2.x 
    fix: #3553827 Colors revert back to default when updating a chart using...
andileco’s picture

andileco commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.