Problem/Motivation

When installing the module, having the strict schema check enabled (service "testing.config_schema_checker" - "Drupal\Core\Config\Development\ConfigSchemaChecker") - I have an error:

In ConfigSchemaChecker.php line 98:
                                                                                                                                                                              
  Schema errors for charts.settings with the following errors: 0 [] The charts.settings config object must specify a language code, because it contains translatable values.

Steps to reproduce

Just install the module with the enabled "testing.config_schema_checker" service, and get an error.

Or write a Nightwatch test having the "charts" module as a dependency.

Proposed resolution

The easiest fix is just to add the langcode property to the default configuration config/install/charts.settings.yml like this:

+ langcode: en
  dependencies: []
  charts_default_settings:

But the question is - does this whole configuration really need to be translatable?

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork charts-3553626

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

murz created an issue. See original summary.

murz opened merge request !178

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented
Status: Active » Needs review

I prepared a MR with adding the langcode: en to the config/install, please review.

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
Status: Needs review » Reviewed & tested by the community

Thanks @murz for the MR.

  • andileco committed 35566041 on 5.1.x authored by murz 
    [#3553626] feat: Schema error: The charts.settings config object must...
andileco’s picture

andileco commented
Status: Reviewed & tested by the community » Fixed

Thank you! Committed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.