Problem/Motivation

We were asked to make revision log messages across all our revision-able content entity types required for a client this year. I saw this module, and while it looked very polished, it only worked for node entities, so we wrote a custom module to support blocks, nodes, and media. We approached the problem a broader scope than this module, but the fundamental idea is similar.

We recently got approval to release our work to the community, and I'm trying to figure out if it makes sense to join forces with this module or create yet another version of "require revision log message".

Unfortunately the code we have is quite different than this module since we were solving for multiple entity types, and there were a number of edge cases we had to consider when expanding the scope. Examples: media library add forms, inline (layout builder) versus reusable blocks, revision log messages on the layout builder form when saving nodes, content moderation integration, etc.

I feel like if we did integrate, the module code we have might need to replace a large section of the code in this module. I'd also really want to be a co-maintainer in that case. It looks like there is some desire to expand to other revision-able entity types per #3293857: Support all entities that implement the RevisionLogInterface.

What are your thoughts? I totally understand if it doesn't make sense to integrate, but I wanted to at least reach out before creating a very similar module.

Comments

jastraat created an issue. See original summary.

jastraat’s picture

Issue summary: View changes
bluegeek9’s picture

Version: 2.0.x-dev » 2.1.x-dev

Hi @jastraat,

I would be happy to join forces. This sounds like the place for your code.

Do you want to make an initial MR under #3293857: Support all entities that implement the RevisionLogInterface? You can use the "3293857-all-entity-type" branch.

I have no issue with you becoming a maintainer; I do not have permissions to add people.

jastraat’s picture

Wonderful! I also felt like collaboration made more sense -

I am slightly concerned though; is kwfinken the only one who can approve maintainers? It looks like he hasn't been very active in the commit log the past two years.

bluegeek9’s picture

It is kwfinken's project. I would not be too worried. He still uses Drupal. If he is unreachable there is a process for the site moderators to make you a maintainer.

jastraat’s picture

I'm afraid I got burned on an earlier project I contributed to substantially and was never able to give our organization credit.

bluegeek9’s picture

StatusFileSize
new19.79 KB

Is this what you mean by credit for your organization?
Supporting Organizations
I can add Supporting Organizations to the project. If your code is merged into the project, I will add your organization.

It is kwfinken's project, so if he does not want you as a maintainer ... it is his project. I cannot imagine an objection.

If kwfinken is un-reachable, and your code is merged into the project, I will voice my support to have you add my the site moderators.

jastraat’s picture

Thank you @bluegeek! Yes, that was what I was referring to.

I spoke with the rest of my team this morning to get their input on the best path forward. While I really appreciate how responsive you've been and I like the code of this module, the team thought it made more sense to go with a separate module.

https://www.drupal.org/project/revision_extras

We're suggesting Require Revision Log Message as a similar module that has a more lightweight approach if someone only needs to require revisions on node entities.

kwfinken’s picture

@jastraat, I just added you as a maintainer. I did not set you up to administer releases until I have gotten a chance to see your code, but either myself or @bluegeek9 can make a release.

After I see the quality of your input, I will grant you ability to make a release, but I too have gotten burned by granting that permission too soon.

kwfinken’s picture

BTW, if you decide to go with a different module and mark this as the "light weight" alternative, I have no problem with that.

jastraat’s picture

@kwfinken That totally makes sense; given that we're going with a separate module, you can remove me as a maintainer. I appreciate the response!

bluegeek9’s picture

Status: Active » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation, including:

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.