In file_browser.install line 57, the backbone path is defined as
$backbone_path = \Drupal::service('library.libraries_directory_file_finder')->find('backbone') . '/backbone-min.js';

Then on line 62 the "backbone-min.js" is appended again

if ($backbone_path) {
        $backbone_path = $backbone_path . '/backbone-min.js';
      }

This results in a path of libraries/backbone/backbone-min.js/backbone-min.js

Line 57 should have the appended filename removed to match the other library checks

Issue fork file_browser-3552424

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

daniel.moberly created an issue. See original summary.

dhansen made their first commit to this issue’s fork.

dhansen opened merge request !22

dhansen’s picture

dhansen commented
Priority: Normal » Major
Status: Active » Needs review

Branch/MR created. I also slipped in some fixes for two other issues:

  • The Masonry version was being incorrectly reported in composer.libraries.json
  • Backbone was being added as a repository in composer.libraries.json, but was not actually being required and so failed to install

Also bumping the priority on this to Major as it can render one feature unusable with no workaround if you're installing from composer.libraries.json and cause a significant admin- or developer-facing bug with no workaround that's appearing in the Status Report.

d.fisher’s picture

d.fisher commented
Status: Needs review » Reviewed & tested by the community

Thank you for this. I'm about to go on leave for 3 weeks so will merge and release now!

d.fisher’s picture

d.fisher commented
Status: Reviewed & tested by the community » Fixed

Fixed and released in 2.0.7.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

d.fisher’s picture

d.fisher commented
Version: 2.0.6 » 2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.