Problem/Motivation

Update the Acquia DAM module to run Canvas PHPUnit tests against the latest stable Drupal Core version instead of the previously pinned 11.2.2.

As part of #3519247: Acquia DAM and Canvas integration, we pinned Drupal Core to 11.2.2 for Acquia DAM Canvas PHPUnit tests, following recommendations from the Canvas team. The Canvas module has now unpinned Drupal Core and is testing against the latest stable version. To maintain consistency and ensure compatibility, we need to update our CI configuration to use the latest stable Drupal Core for Acquia DAM Canvas PHPUnit tests.

Proposed resolution

Remove the Drupal Core 11.2.2 pin from Acquia DAM Canvas PHPUnit CI configuration.

Issue fork acquia_dam-3551999

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vishalkhode created an issue. See original summary.

vishalkhode’s picture

vishalkhode commented
Parent issue: » #3519247: Acquia DAM and Canvas integration
Related issues: -#3519247: Acquia DAM and Canvas integration

vishalkhode opened merge request !208

vishalkhode’s picture

vishalkhode commented
Status: Active » Needs review
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Needs work

The kernel tests with Canvas is failing in the next minor release. Lets look at that before it gets merged?

vishalkhode’s picture

vishalkhode commented
Status: Needs work » Needs review

The test is failing, because of the Canvas module. Canvas provides a config i.e editor.editor.canvas_html_block and it's missing styles properties. This property is introduced in Drupal Core as part of #3274635: [upstream] Use CKEditor 5's native <ol type> and <ul type> UX. Take a look at here in the config schema and it's required key (as it contains NotNull constraint). Once canvas updates the config, the test should pass.
Hence, moving it back to Needs Review.

The kernel tests with Canvas is failing in the next minor release. Lets look at that before it gets merged?

  • japerry committed e1dab490 on 1.1.x authored by vishalkhode 
    #3551999: Unpin Drupal Core version for Acquia DAM Canvas PHPUnit Tests.
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Got it, thanks for the clarification. Merged!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.