Problem/Motivation

Follow up work after the first check-in with subsystem and topic maintainers showed that the doc page for past core maintainers is not being kept up to date.

Steps to reproduce

Proposed resolution

Output a message that MAINTAINERS.txt has been changed so that can past core maintainers can be updated if needed. The issue should be tagged with 'needs documentation' and a link to the instruction page.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#12 3551970-nr-bot_vexuwvki.txt627 bytesneeds-review-queue-bot

Issue fork drupal-3551970

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !13481

quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented

Sorry not following what is this checking exactly?

quietone’s picture

quietone commented
Issue summary: View changes

I updated the IS with more detail.

Also, the link to the instruction page should probably be an alias. The page is likely to be moved to a new guide, but I wanted to see if others thought this approach was a worthwhile idea.

smustgrave’s picture

smustgrave commented

Would it be its own step? Not sure if it would get seen if it’s outputted somewhere people don’t always check.

Example the config validate step. Never would know that changed if it didn’t highlight yellow

ghost of drupal past’s picture

ghost of drupal past
he/him
commented

-- small footnote, no idea where to put this, the issue reminded me: the handbook page lists pwolanin as book maintainer only since 8.0, he has been the book maintainer de facto since he rewrote it in 146425 in 2007 for the new menu system he and I did so that's drupal 6.0. He was officially only added in 2010 in the big maintainers revamp in 621618 but that's just an oversight.

quietone’s picture

quietone commented

@ghost of drupal past, thanks for the information. I will try to update it with that information in the next week. I have been going through the git history but have limited the searches to core/MAINTAINERS.txt, so pretty much Drupal 8+.

As for where to put this, I guess another way is to make an issue and tag it 'project governance'.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Since @quietone does most of the work for this file. Going to mark as it seems non disruptive to other things.

longwave made their first commit to this issue’s fork.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3551970-nr-bot_vexuwvki.txt627 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Bot rebellion

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

I think this is a good idea to notify committers, as I don't remember always to do this :)

Backported to 11.x to keep things in sync, it doesn't matter too much as all these commits will go to main first.

Committed and pushed cf6401bcee0 to main and 9043270b5e3 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 9043270b on 11.x 
    fix: #3551970 Check in commit-code-check for changes to MAINTAINERS.txt...

longwave closed merge request !13481

  • longwave committed cf6401bc on main 
    fix: #3551970 Check in commit-code-check for changes to MAINTAINERS.txt...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.