Problem/Motivation

Contact module is being deprecated. Usages in tests not in Contact needs to removed and test coverage moved to the Contact module.

  1. ✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationCacheTest.php
  2. ✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationListUiTest.php
  3. ✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationOverviewTest.php
  4. ✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTestBase.php
  5. ✅ core/modules/locale/tests/src/Functional/LocaleConfigTranslationTest.php

Steps to reproduce

Proposed resolution

Replace use of Contact in config_translations tests with another module

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3551599

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

penyaskito made their first commit to this issue’s fork.

penyaskito opened merge request !13464

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes
Status: Active » Needs review

Disclaimer: I didn't check if the list on the IS was exhaustive.

✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationCacheTest.php
Just removal, contact wasn't even used
✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationListUiTest.php
I think the test is still relevant, moved the contact parts to contact module
✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationOverviewTest.php
Just removal, contact wasn't even used
✅ core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTestBase.php
Only one of the child classes had a relevant test, I think it's still helpful so moved that into contact.
✅ core/modules/locale/tests/src/Functional/LocaleConfigTranslationTest.php
This was definitely the most complex one: if I got this right, we wanted to test a module default provided config that was used in some upcasting in routes. The choices are quite limited, so I ended up using provided languages. Being a translation test makes it even harder to follow🤦🏽. Hopefully the extensive comments I added help with following the flow.
dcam’s picture

dcam commented
Status: Needs review » Needs work

I left a suggestion for the extended Locale test comment. I thought it needed some simplification and clarification. Otherwise this is looking good to me.

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +Vienna2025

Looks ready to go

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +11.3.0 release priority
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 2901c8e4 on 11.3.x 
    Issue #3551599 by quietone, penyaskito, dcam, andypost: Remove use of...

  • catch committed a179a99e on 11.x 
    Issue #3551599 by quietone, penyaskito, dcam, andypost: Remove use of...

catch closed merge request !13464

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.