Closed (fixed)
Project:
Sticky Local Tasks
Version:
2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Oct 2025 at 19:23 UTC
Updated:
8 Dec 2025 at 21:59 UTC
Jump to comment: Most recent
Comments
Comment #2
andyf commentedIt looks like this might've been introduced in 38557cb8689c0ac8a48711565f5224939e398cca. That removed the
hide-default-local-taskslibrary (although it still gets conditionally attached in\Drupal\sticky_local_tasks\StickyLocalTasksBuilder::build()).Also the config setting was removed in ec7ba618eabf0e2b97e03cec1f3f5af04fd99fbc so the initial part of the test would fail because it expects the hidden setting to be enabled by default.
As an aside, I was wondering if it might make sense to use a javascript test and check the actual visibility of the links rather than the presence of a CSS file?
Comment #4
jan kellermann commentedThank you! Sometimes we overlook the obvious...
Please review :)
Comment #5
jan kellermann commentedComment #6
jan kellermann commentedComment #7
andyf commentedThanks @jan kellermann. I've done a code review but haven't tested it yet. Because we released 2.0.2 without the config setting
usage_options.hide_default_local_tasksset to true, it's possible some users have installed that version and haven't got the config correctly set. I think we should also add ahook_update_N()function that checks if the key exists, and if not adds it and sets it to true. I'm happy to have a go at this, but won't be able to take a look until tomorrow at the earliest.Comment #8
jan kellermann commentedThank you for review. Good point. I added an entry in hook_update(). Please just have a look.
Comment #9
andyf commentedLooks great, thanks! Reviewed and tested, the hook update works, toggling the config option actually affects the display of the tasks, and the config validates. Just one super minor nitpick over a comment...
Comment #10
jan kellermann commentedGreat, thank you! I fixed this and merged this MR.