Problem/Motivation

In release 3.0.0-beta21 dependency was added on drupal/action module (the reason is that in Drupal 11 the module was removed from core).

However, I wonder if a hard dependency is required. I can use the module without the Action module enabled on D11.

Note: When I update moderated_content_bulk_publish to the latest release, the Action module doesn't get enabled, only the module files are pulled by composer.

Steps to reproduce

1. Update moderated_content_bulk_publish to 3.0.0-beta21
2. The composer requirement pulls in the module, but it's not getting enabled, you need to do it manually if you need it.

Proposed resolution

Consider removing the requirement for drupal/action.

Maybe it would be enough to add a section about drupal/action in the README for projects that want to use its functionality?

It's possible that I'm not aware of some functionality that does require the action module. Let me know if that's the case.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

keszthelyi created an issue. See original summary.

keszthelyi’s picture

Issue summary: View changes
keszthelyi’s picture

Issue summary: View changes
joseph.olstad’s picture

Hi this must have been my mistake, the automated tests are using it.

Thanks for reporting , I'll have to unwind this.

joseph.olstad’s picture

Assigned: Unassigned » joseph.olstad
joseph.olstad’s picture

Assigned: joseph.olstad » Unassigned
Status: Active » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

keszthelyi’s picture

Hi @joseph.olstad

I see that you removed action as a dependency, but it's still required in composer:
https://git.drupalcode.org/project/moderated_content_bulk_publish/-/blob...

If it's needed for the tests for some reason, it could be moved to the require-dev section.

joseph.olstad’s picture

no it's not needed in the tests afaik either.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.