Problem/Motivation

I noticed that the composer.json for fluidui requires that drupal/libraries is installed. But libraries is not a listed dependency in the info.yml file, and not having libraries installed did not impact whether it worked*, so I have been operating for a while where libraries is downloaded as part of the composer requirements but then not installed. That's not a significant problem but does mean a bit more time to build from composer, a bit more that needs updated, a bit more clutter in the list of extensions, and a bit of confusion why it is there without being installed.

* Maybe there's a connection between this and the issue since 2.0.2 with the beige background, but installing libraries did not fix that for me, so if it is related, it is more complicated than simply enabling it.

Proposed resolution

If it is not actually required, remove that requirement from the composer file. If it is actually required, add that dependency to the info file.

Issue fork fluidui-3550149

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ryanrobinson_wlu created an issue. See original summary.

ishani patel made their first commit to this issue’s fork.

ishani patel’s picture

ishani patel commented
Assigned: Unassigned » ishani patel

ishani patel opened merge request !50

ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review

@ryanrobinson_wlu,
I've raised PR.
Kindly review it.

ryan-l-robinson’s picture

ryan-l-robinson commented

Please correct me if I'm misunderstanding, but I think this is now saying it is not required in composer, meaning the code will not be installed in the standard composer processes, and then it is required for enabling of fluidui. That is a similarly confusing combination as the status quo to me, but in reverse.

Is libraries required for fluidui to function, or not?

danrod’s picture

danrod
Location Ottawa
commented
Assigned: Unassigned » danrod
danrod’s picture

danrod
Location Ottawa
commented

Actually, it looks like the Libraries module is not needed at all. I can just remove it, I'll update the MR.

danrod’s picture

danrod
Location Ottawa
commented
Version: 2.0.2 » 2.0.x-dev
danrod’s picture

danrod
Location Ottawa
commented

I merged the MR (along with some minor changes) and indeed the libraries dependency is not needed at all, I tested the 2.0.x-dev release in a new D10.5.3 instance and worked with no issues.

Thanks a lot to everyone involved.

danrod’s picture

danrod
Location Ottawa
commented
Status: Needs review » Reviewed & tested by the community
danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.