Drupal Version

Drupal 10.5.3, Claro admin theme

Domain module version

2.0.0-beta5

Steps to reproduce

After upgrading to domain 2.0.0-beta5, when I edit a node, the Domain Source field is no longer nested in the Domain Settings fieldset in the sidebar.

domain source field

CommentFileSizeAuthor
#3 domain-source-beta4.png171.03 KBcindytwilliams
domain-source-field.png248.81 KBcindytwilliams

Issue fork domain-3550142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cindytwilliams created an issue. See original summary.

mably’s picture

mably commented

Was it working fine in beta4 ?

cindytwilliams’s picture

cindytwilliams commented
StatusFileSize
new domain-source-beta4.png171.03 KB

Yes, here's how it displayed in beta4:

beta 4 field

mably’s picture

mably commented

Ok, thanks, will have a look at it.

mably’s picture

mably commented

For some reason, domain_source_form_node_form_alter is now executed before domain_access_form_node_form_alter, which causes the issue.

EDIT:

I’ve found the culprit:

/**
 * Increase the module weight to run hooks after Content Translation.
 */
function domain_access_update_10002() {
  // Use a higher weight than content_translation (10).
  // @see https://www.drupal.org/project/domain/issues/3367186
  module_set_weight('domain_access', 20);
}

Added this to domain_source to fix the problem:


/**
 * Increase the module weight to run hooks after Domain Access.
 */
function domain_source_update_10001() {
  // Use a higher weight than domain_access (20).
  // @see https://www.drupal.org/project/domain/issues/3550142
  module_set_weight('domain_source', 30);
}

mably opened merge request !238

mably’s picture

mably commented

@cindytwilliams could you give a try to this issue's MR?

cindytwilliams’s picture

cindytwilliams commented
Status: Active » Reviewed & tested by the community

Thanks, I can confirm that applying the changes in this MR and then running the hook_update fixes this issue.

  • mably committed 341184af on 3.x 
    Issue #3550142 by cindytwilliams, mably: Domain Source field moved...

  • mably committed 1244e0e3 on 2.0.x 
    Issue #3550142 by cindytwilliams, mably: Domain Source field moved...
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.