Problem/Motivation

Using #[Group('legacy')] is wrong, #[IgnoreDeprecations] should be used instead.

See https://www.drupal.org/node/3447698.

Proposed resolution

Fix some more that slipped in:

  • core/modules/views/tests/src/Functional/Update/RssDefaultRowViewModeUpdateTest.php
  • core/modules/page_cache/tests/src/Unit/PageCacheLegacyTest.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3549970

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

nexusnovaz’s picture

nexusnovaz commented
Assigned: Unassigned » nexusnovaz

Ill take a look at this

nexusnovaz changed the visibility of the branch 3549970-use-ignoredeprecations-instead to hidden.

nexusnovaz changed the visibility of the branch 3549970-use-ignoredeprecations-instead to active.

nexusnovaz opened merge request !13392

nexusnovaz’s picture

nexusnovaz commented
Assigned: nexusnovaz » Unassigned
Status: Active » Needs review

Please can someone review MR !13392

Thanks!

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work

Changes are good, but maybe the update test does not need to ignore deprecations in the first place. Worth trying to remove the attribute and see if the test still passes?

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Totally agree with you @mondrake, pushed the commit with the required changes. Hence moving into review.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Fixed » Reviewed & tested by the community

not pushed

catch closed merge request !13392

  • catch committed 822a8bca on 11.x 
    Issue #3549970 by mondrake, nexusnovaz, ankitv18: Use #[...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Pushed...

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.