Problem/Motivation

Using #[Group('legacy')] is wrong, #[IgnoreDeprecations] should be used instead.

See https://www.drupal.org/node/3447698.

Proposed resolution

Fix Drupal\Tests\package_manager\Unit\ExecutableFinderTest .

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3545592

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

nexusnovaz made their first commit to this issue’s fork.

ankitv18 opened merge request !13187

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Status: Active » Needs review

MR is ready for a review.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Bug Smash Initiative

Trivial MR.
Issue summary and title match the diff.
Pipeline is green, other than the PHP 8.5 warnings.
Tagging to be smashed.

Nothing else to do or improve that I see, unless we want a follow-up to add something to automatically flag further regressions to using the legacy group?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3497124: Deprecate expectDeprecation(), use PHPUnit's expectUserDeprecationMessage*() instead

#6: #3497124: Deprecate expectDeprecation(), use PHPUnit's expectUserDeprecationMessage*() instead will cover that in the sense that after it, #[Group('legacy')] will just be a group like any other and any deprecation thrown during the test will make the test fail. So I wouldn't do anything additional right now; let's play whackamole when they pop up.

  • catch committed 520296f6 on 11.x 
    Issue #3545592 by mondrake, ankitv18: Use #[IgnoreDeprecations] instead...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I think given this was tagged novice it could have been left a couple of days to see if an actual novice picked it up. Good to further unblock PHP 11/12 support though.

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

catch closed merge request !13187

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.