Problem/Motivation

DraggableViews includes one hook, hook_draggableviews_join_withargs(), though others are proposed and have been useful in previous versions (#3518723: Add hook draggableviews_sorted after view is saved).

Proposed resolution

Documenting all hooks in a standard file, draggableviews.api.php will make hooks more discoverable.

Issue fork draggableviews-3549815

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

calebtr created an issue. See original summary.

calebtr opened merge request !49

calebtr’s picture

calebtr commented
Status: Active » Needs review

The merge request pipeline indicates failures, but they do not look related to the code changes here.

istryker’s picture

istryker commented
Status: Needs review » Postponed (maintainer needs more info)

I cannot find that hook in 2.1.x. I believe you are referencing D7

calebtr’s picture

calebtr commented

In the 2.1.x branch, hook_draggableviews_join_withargs() is invoked from Drupal\draggableviews\Plugin\views\join\WithArgs::buildJoin() on line 29:

    \Drupal::moduleHandler()->alter('draggableviews_join_withargs', $view_args, $context);
calebtr’s picture

calebtr commented
Status: Postponed (maintainer needs more info) » Needs review

  • 3fd8efd3 committed on 2.1.x 
    Issue #3549815 by calebtr, iStryker: Add API documentation for...
istryker’s picture

istryker commented
Status: Needs review » Fixed

Awesome, done! I remove the example as Drupal.org specifies there shouldn't examples....though I added it to the comment.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

istryker closed merge request !49

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.