I'd like to popose ViewsFiltersSummary::buildFilterDefinitions() extension to support:

  1. Entity reference fields, including, dynamic entity references, Select 2 lists with AJAX autocomplete
  2. Boolean fields, where by default field label is displayed, when filter is active (instead of it's value)
  3. Improve list_field by adding 2D array support. Sometimes we build lists with groups (), this is not working with current implementation of list_field.
CommentFileSizeAuthor
#3 views_filters_summary-3548104-3.patch7.71 KBgugalamaciek

Comments

gugalamaciek created an issue. See original summary.

gugalamaciek’s picture

gugalamaciek commented
Issue summary: View changes
gugalamaciek’s picture

gugalamaciek commented
StatusFileSize
new views_filters_summary-3548104-3.patch7.71 KB
mably’s picture

mably commented

@gugalamaciek those patches are quite unreadable and not easy to review.

Could you provide an MR please?

This issue should likely be split into three separate issues.

mably’s picture

mably commented
Issue tags: +Needs steps to reproduce
gugalamaciek’s picture

gugalamaciek commented

Yeah, I know. I’m short on time right now, but I’ll try to explain it better and add an MR when I get a free minute. For now, if someone needs it, can use the patch ;)

mably’s picture

mably commented

Ok, on my side I have been working on a separate issue for the boolean part: #3548230: Use exposed label for boolean filters when labels are disabled.

mably’s picture

mably commented

Boolean label and 2D option values have been merged.

Only the entity reference filter remaining.

mably’s picture

mably commented

@gugalamaciek what module are you using for your entity reference filters?

mably’s picture

mably commented

I guess you are using this module:

https://www.drupal.org/project/views_core_entity_reference

Let's see what we can do about it.

Related issue: #3548654: Compatibility with the Views Core Entity Reference module

mably’s picture

mably commented
Assigned: gugalamaciek » Unassigned
Status: Active » Fixed

3 related issues have been merged.

Let's mark this as fixed.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

mably’s picture

mably commented
Issue tags: -Needs steps to reproduce
gugalamaciek’s picture

gugalamaciek commented
Status: Fixed » Closed (fixed)