Problem/Motivation

Process isolation in PHPUnit 12 must be specified on each concrete test class.

Proposed resolution

In this issue, add #[RunTestsInSeparateProcesses] attribute to all Functional/FunctionalJavascript tests.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 3547849-nr-bot_hhu437v6.txt608.22 KBneeds-review-queue-bot

Issue fork drupal-3547849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !13289

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review

mondrake changed the visibility of the branch 3547849-add-runtestsinseparateprocesses-attribute to hidden.

mondrake changed the visibility of the branch 3547849-add-runtestsinseparateprocesses-attribute to active.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3546029: Ensure that #[RunTestsInSeparateProcesses] attribute is added to all Kernel tests
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3547849-nr-bot_hhu437v6.txt608.22 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
Issue tags: +no-needs-review-bot
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Nightmare of a ticket to review. But @mondrake has been on top of these phpunit 12 changes and this looks like a rector fix so believe we should be good. Sure it will require some slack coordination to rebase before commit.

catch’s picture

catch
he/him
Primary language English
commented

I got this trying to commit the patch with the usual git hooks:

Unable to launch a new process: proc_open(): posix_spawn() failed: Argument  
   list too long

Never actually seen that before.

Since this is green and the MR passes, going to go ahead and commit with skip checks, worst case we need to revert.

  • catch committed f97180dc on 11.x 
    Issue #3547849 by mondrake: Add #[RunTestsInSeparateProcesses] attribute...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

catch closed merge request !13289

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.