Problem/Motivation

When using the "Custom Value" property, It'd be useful if the users could contextually view the available tokens for a given datasource.

Proposed resolution

It'll detect the token type from the datasource or the existing token, then provide the available tokens afterwards.

UI showing available tokens for the current 'media' token

Remaining tasks

Provide MR.

CommentFileSizeAuthor
#2 search-api-3547428-contextual-token-patterns.png73.71 KBcodebymikey

Issue fork search_api-3547428

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

codebymikey commented
Issue summary: View changes
Status: Active » Needs review
Related issues: +#3414348: Document Search API token field processor
StatusFileSize
new search-api-3547428-contextual-token-patterns.png73.71 KB

codebymikey opened merge request !273

drunken monkey made their first commit to this issue’s fork.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Great idea, thanks! Didn’t realize it was that easy to get a token browser dialog …
Anyways, I think we can improve on the types shown, but otherwise this looks great. Please check out my revisions and tell me what you think – if they look good to you I’ll merge.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +Vienna2025
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Thanks for your comments!
I can see your reasoning, especially if you only ever used one type of token here, but I can easily imagine other users mixing token types so we should support that, too. While potentially annoying, performance in the admin UI isn’t a primary concern.

Would you say this is RTBC then?

codebymikey’s picture

codebymikey commented
Status: Needs review » Reviewed & tested by the community

Would you say this is RTBC then?

Yup, given '#global_types' already defaults to TRUE, it doesn't need to be explicitly declared. Marking this as RTBC.

Thanks for the input and getting this over the line!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Great to hear, thanks!
Merged.
Thanks a lot again for this nice improvement!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: General code » User interface

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.