Call to imageapi_get_available_toolkits() breaks install profiles [#354719]

The call to imageapi_get_available_toolkits() in hook_requirements() introduced here:

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/imageapi/im...

breaks install profiles. When installed at the same time as imageapi, imageapi_get_available_toolkits() will not be available in hook_requirements().

Will post an attempt to fix soon.

Comment	File	Size	Author
#1	354719_install_profiles.patch	1.27 KB	alex_b

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

alex_b CreditAttribution: alex_b commented 5 January 2009 at 21:27

Status:

Active

» Needs review

File	Size
354719_install_profiles.patch	1.27 KB

This patch checks for the existence of the function before it calls it. Not ideal, I guess, but might fly as this condition will be only met in install profiles (?).

Comment #2

alex_b CreditAttribution: alex_b commented 5 January 2009 at 21:27

I guess this issue also concerns 6.x

Comment #3

alex_b CreditAttribution: alex_b commented 5 January 2009 at 21:27

Assigned:

alex_b

» Unassigned

Comment #4

drewish CreditAttribution: drewish commented 5 January 2009 at 22:20

The fix used in the D6 version is to check the phase.

  // Check this at runtime rather than install time because the order of
  // installation doesn't take dependencies into account. ImageAPI may have
  // been installed by not loaded and if we report a requirement error
  // because we can't find its function or no toolkit is enabled modules that
  // depend on us will still be enabled but will have a missing dependency.
  // Seems like a better idea to let everything get enabled and then inform
  // them of the problem.
  if ($phase == 'runtime') {
    if (count(imageapi_get_available_toolkits()) == 0) {
      $requirements['imageapi_toolkits'] = array(
        'title' => $t('ImageAPI Toolkit'),
        'value' => $t('No ImageAPI toolkits available'),
        'severity' => REQUIREMENT_ERROR,
        'description' => $t('ImageAPI requires a Toolkit such as ImageAPI GD or ImageAPI ImageMagick to function. Goto !modules and enable one of them.', array(
'!modules' => l('admin/build/modules', 'admin/build/modules'))),
      );
    }
  }